search

mozilla / overscripted

Repository for the Mozilla Overscripted Data Mining Challenge
Mozilla Public License 2.0
74 stars 53 forks source link

Audio code looks for createOscillator instead of oncomplete #108

Closed birdsarah closed 4 years ago

birdsarah commented 5 years ago

https://github.com/mozilla/overscripted/blob/master/analyses/2019_03_willougr_fingerprinting_implementation_sixth_sense/Audio%20Fingerprinting%20Heuristics.ipynb

cell 15 reads:

on_complete_df = df[df.symbol == 'OfflineAudioContext.createOscillator']
on_complete_urls = on_complete_df.script_url.unique().persist()

pretty sure that should be oncomplete

birdsarah commented 5 years ago

ping @willougr