search

mozilla / overscripted

Repository for the Mozilla Overscripted Data Mining Challenge
Mozilla Public License 2.0
74 stars 53 forks source link

Add resources to README #41

Closed asquare14 closed 5 years ago

asquare14 commented 5 years ago

Mentioned about these resources on gitter.

birdsarah commented 5 years ago

This PR doesn't make sense in context with your earlier one, now merged. I like the idea of moving that piece to a resources section - maybe at the bottom near the glossary.

Other small tweaks - consider rewriting the "please update readme based on our learnings" to something that reads better for a newcomer.

Maybe lets rename that section "New contributor tips"

asquare14 commented 5 years ago

Sure. Will do that

asquare14 commented 5 years ago

@birdsarah Is this ok ?

birdsarah commented 5 years ago

Instead of "is this ok?" you can just say "ready for review" or, better yet, when you're working on PR you can add "WIP" which stands for "work in progress" to the title. And when you're done remove the "WIP" ... I could also add labels to help with this process.

You'll find out the answer to the question "is this ok?" on review. But review is always an iterative process.

asquare14 commented 5 years ago

Thanks ! Will write Ready for review next time.

On Wed, Mar 13, 2019, 11:44 PM Sarah Bird notifications@github.com wrote:

Instead of "is this ok?" you can just say "ready for review" or, better yet, when you're working on PR you can add "WIP" which stands for "work in progress" to the title. And when you're done remove the "WIP" ... I could also add labels to help with this process.

You'll find out the answer to the question "is this ok?" on review. But review is always an iterative process.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/overscripted/pull/41#issuecomment-472543577, or mute the thread https://github.com/notifications/unsubscribe-auth/AV4EVbc2gzctgmbwu6oRnPvg9253tE7uks5vWT_zgaJpZM4bswRi .