Closed PetalsOnWind closed 5 years ago
No rush @PetalsOnWind, but whenever you'd like review go ahead and remove WIP from the title.
@birdsarah I removed the WIP. Can you please check? (There might be some repetitions from other ipynbs, I don't know if I should keep them)
Can you clarify what you mean by:
There might be some repetitions from other ipynbs, I don't know if I should keep them
If you mean you have used other people's code in your analysis. That's fine, but you must add a citation. It will reflect poorly on your notebook if you haven't done so. Basic things like opening a file, and filtering it are obviously the same for everyone so use your judgement. If you know you copy-pasted something, cite it.
I may be misinterpreting your meaning, and if so I apologize. But I want to give you the opportunity to fix citation omissions before I review.
Can you have a look now? @birdsarah
Yes!
I hope my comments didn't come across too negative, they weren't intended as such. I've just been through and cleaned up a little of the language from the comments I made as I was scrolling through the notebook.
Just to emphasize again, there's a lot of good stuff in there, and I look forward to seeing the next iteration. And congratulations, there's a LOT to get to grips with getting started with this dataset and you are well on your way.
Closing this PR due to lack of activity, please feel free to reopen.
Comparing the observations in Ghostery Study "Tracking the Trackers" (https://www.ghostery.com/lp/study/) and seeing how the results from the sample conform to that analysis. Will close #35 after completion.