mozilla / overscripted

Repository for the Mozilla Overscripted Data Mining Challenge
Mozilla Public License 2.0
74 stars 53 forks source link

Kingcyrus issue35 analysis #99

Closed KingCyrus closed 4 years ago

KingCyrus commented 5 years ago

Hi. I was able to make a function that filters a dataset to show where calls to local storage APIs were made. The local storages considered are:

  1. window.document.cookie
  2. window.localStorage
  3. window.sessionStorage

Thanks

birdsarah commented 5 years ago

@KingCyrus you still have checked in the parquet dataset.

You need to: 1) copy the analysis files somewhere, temporarily e.g. Desktop 2) checkout master 3) make a new branch 4) copy the files into your new branch 5) add, commit, push

Alternatively, given that you committed the parquet file in it's own commit, you can use git cherry-pick it goes something like this:

git checkout master   # back to master
git checkout -b kingcyrus_analysis  # open a fresh branch
git cherry-pick a19ad449baa37921a0b60f142daf907f12d2c593  # grab the 2019_04_KingCyrus_#35_uniqueIDs_in_dataset commit
git cherry-pick 40f9a35aa29dc16dd42ac16cbaaf543ff94c8932  # grab the modified function notebook commit
git cherry-pick b76833c # grab the last commit
# Then push branch and open new PR
KingCyrus commented 5 years ago

Good morning from here. Thanks for the review. I am looking at it while reading up some suggested articles to enable me do proper analysis.

aliamcami commented 4 years ago

Closing this PR due to lack of activity, please feel free to reopen.