search

mozilla / page-metadata-parser

DEPRECATED - A Javascript library for parsing metadata on a web page.
https://www.npmjs.com/package/page-metadata-parser
Mozilla Public License 2.0
270 stars 42 forks source link

Parse high-res icons fixes #85 #86

Closed jaredlockhart closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c7c7a435c9ef7cfec9c54bcf686b65bea0e22899 on 85 into 0b30906cd7d9fb378b789b91433f12efe3cdc45c on master.

rlr commented 7 years ago

This looks good. I think we might want a special case for when sizes="any". For example, I say this on yahoo: <link rel="icon" href="https://s.yimg.com/os/mit/media/p/common/images/favicon_new-7483e38.svg" sizes="any">. Although, now that I think about it, if they have an svg like this they are very unlikely to have more than one size listed. I think I've convinced myself that you maybe don't need to handle that.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 283b3315c4a1d2de7510dba46a9d893756a24b74 on 85 into 0b30906cd7d9fb378b789b91433f12efe3cdc45c on master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 678a98d9d51cb3c4e69deafaa5b5a3a86b4bd20d on 85 into 0b30906cd7d9fb378b789b91433f12efe3cdc45c on master.

rlr commented 7 years ago

💃