Remove premail caching - Githubissues

mozilla / payments-service

This is a web service to support the Mozilla Payments web UI.

Other

5 stars 7 forks source link

Remove premail caching #112

Closed andymckay closed 9 years ago

andymckay commented 9 years ago

fixes #110

the hacks were just ridiculous and annoying me
this reduces the complexity greatly and makes it premail dynamically

muffinresearch commented 9 years ago

So the one bit I wonder about is the CSS fetching that premailer does. Is that going to be smart about not fetching it every time - also if the css was not returned for whatever reason will it fallback to a stale version or will the styling of the email just be borked?

muffinresearch commented 9 years ago

Simplicity FTW r+wc

andymckay commented 9 years ago

It's not going to be smart about that, it will just fail. The premailing of the template (what this removes) was an attempt to address that option, but it ended becoming too complicated. I can't help but think that the answer is something around: https://github.com/mozilla/payments-service/issues/111