Marketplace in-app payment tests (on dev) are failing

mozilla / payments

The root repository for all things Payments at Mozilla.

Other

9 stars 9 forks source link

Marketplace in-app payment tests (on dev) are failing #92

Open andymckay-limited-access opened 9 years ago

andymckay-limited-access commented 9 years ago

Our tests for in-app payments for marketplace on FxOS have not been running for some time. I am trying to resurrect them now, using the test app at https://github.com/kumar303/inapp-pay-test. I am getting as far as clicking the Pay button and then logging in with FxA, but after successfully logging in I get an error on the device: “Error - An unexpected error occurred. BAD_JWT_ISSUER”.

Those are running against the -dev server, let's see if we can get those working again.

bobsilverberg commented 9 years ago

cc'ing @bobsilverberg and @krupa

kumar303 commented 9 years ago

The dev database got reloaded yesterday which means the credentials for the tester app are no longer valid. We'll try to fix them up for you shortly.

krupa commented 9 years ago

@washort will make a test app with in-app payments for our test.

bobsilverberg commented 9 years ago

Thanks @krupa and @washort. Please let me know once it's ready and I'll update the tests to use it.

kumar303 commented 9 years ago

Thanks @washort ! It's almost there, the public_id just needs to be set so that the functional tests can be fully configured with static values. Details: https://github.com/mozilla/zamboni/pull/3184/files#r34797890

kumar303 commented 9 years ago

Cool, I think this is ready now. @bobsilverberg can you try configuring your in-app payment test to use these credentials when making a payment? Ping me on IRC if you have questions. I haven't seen the test so I don't know exactly how it's configured.

KEY = 'fake data public ID'
SECRET = 'fake data secret key'

kumar303 commented 9 years ago

Summary on where we're at:

we need one more patch to keep public IDs unique per app, @washort is working on it
we'll need jason to run the fake data script on dev before we can make the BAD_JWT_ISSUER error go away
note to self: I'll need to push an update to http://inapp-pay-test.paas.allizom.org/ when we have the new public IDs

washort commented 9 years ago

This should be ready to try again.

bobsilverberg commented 9 years ago

Thanks @washort. I tried again and got a different error this time: "SIM_ONLY_KEY". I mentioned this to @kumar303 in IRC.

kumar303 commented 9 years ago

I think I have a patch for that: https://github.com/mozilla/zamboni/pull/3186

kumar303 commented 9 years ago

Now we're stuck on:

 Product cannot be purchased due to configuration error. NO_VALID_SELLER

This is because the fake data script is not configuring a seller for the app. This is what the fake data script needs to do:

create a payment account with Zippy (the mock dev payment provider). Zippy is sometimes called Reference. The devhub handles this form submission in payments_accounts_add.
configure the app to use the newly created payment account. Devhub handles this form submission in payment_accounts_form.

andymckay commented 9 years ago

Any progress on this @washort?