mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.2k stars 9.82k forks source link

Sheetmusic - Noteheads doesn't render correctly (font-issue?) #1107

Closed saebekassebil closed 12 years ago

saebekassebil commented 12 years ago

Hi guys,

Here's a bug that has been annoying me for quite some time now, and I'm not really sure what the problem is. My guess is that it's a font-issue, but I though you'd had them fixed? Anyway, the document is mine and I don't claim it anything but copyleft.

http://min.us/m4l4KtQyV

btw: Is there some specific tool you use to inspect the pdf-files? So that I could try to look into such issues myself?

gigaherz commented 12 years ago

I just tried it and it seems to work fine here. I'd suggest you try with the newest build available at https://addons.mozilla.org/en-US/firefox/addon/pdfjs/ or http://mozilla.github.com/pdf.js/extensions/firefox/pdf.js.xpi (probably newer, more experimental too)

And if it still doesn't work, specify which browser (name and version) and operating system (name, version, platform) you use, so the devs can narrow down the possible issues.

EDIT: the newest version appears to be at https://addons.mozilla.org/en-US/firefox/addon/pdfjs/versions/ it doesn't show up in the main page (probably didn't pass the verification process)

wfwalker commented 12 years ago

saebekassebil: i've seen a few sheet music problems like this -- do you know which music notation program was used to create this?

notmasteryet commented 12 years ago

Hmmm... i don't see any issue on my computer as well. Could you provide the description of the defect and/or screenshot, as well as the info about OS and browser as well?

saebekassebil commented 12 years ago

Windows 7, Firefox 9.0.1 Release, I'm on the latest commit on my mozilla branch, and it doesn't work there either. @wfwalker I've created this with Sibelius, @notmasteryet http://minus.com/mZVuEAXW2

notmasteryet commented 12 years ago

Unable to replicate on my Windows 7, Firefox 9.0.1 / pdf.js 0.2.118.

@saebekassebil it's possible, please post the information from the about:support page (filter the sensitive info, so at least Graphics section)

saebekassebil commented 12 years ago

Hmm very weird. My about:support graphics section (Danish, with some translation):

Adapter-beskrivelse:        ATI Mobility Radeon HD 5650 
Producentidentifikation:    1002
Enhedsidentifikation:       68c1
Adapter-RAM:            1024
Adapter-drivere:        atiu9p64 aticfx64 aticfx64 atiu9pag aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64
Driver-version:         8.692.1.0
Driver-dato:            1-22-2010
Adapter-RAM (GPU #2):       Unknown
Adapter-drivere (GPU #2):   Unknown
Direct2D aktiveret:     Not supported, try opgrading you driver to version 10.6 or newer.
DirectWrite aktiveret:      true (6.1.7601.17563)
ClearType parametre:        Gamma: 2200 Pixel Structure: RGB ClearType Level: 100 Enhanced Contrast: 50 
WebGL Rendering:        Not supported, try opgrading you driver to version 10.6 or newer.
Vinduer med GPU grafikacceleration: 0/1. Not supported, try opgrading you driver to version 10.6 or newer.

My DirectX version is 11, if that has anything to do with it.

but: I've just followed some instructions for activating Direct2D for Firefox, and now it works - well at least sort of, 'cause I can now see the noteheads, but all text is rendered in bold now, and somewhat not as good as before, so I think I'll change it back. Btw.: I'm now using Firefox 10.0, though I don't think it has anything to do with the change.

The instructions I followed can be found here: http://www.askvg.com/how-to-enable-direct2d-directwrite-hardware-acceleration-in-mozilla-firefox/

EDIT: Yea just checked, the issue is, when toggling between DirectWrite enabled config setting - per default it's false, but when enabling it, the score renders fine, but all text seems cluttered and bold or the opposite very thin?

notmasteryet commented 12 years ago

opgrading you driver to version 10.6 or newer

Could you upgrade the ATI Mobility Radeon HD 5650 driver to the newer version?

My DirectX version is 11, if that has anything to do with it

Maybe. DirectX on my computer is 10, and both DirectWrite and Direct2D is true.

P.S. See also https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers

saebekassebil commented 12 years ago

Ahh, thanks! Upgrading my driver was fantastic, wasn't aware that a new version had been released. It works well on Firefox 10.0 now, except some missing symbols! All rests with a lower value than a crotchet and minim noteheads are not rendered!

Image of issue: http://min.us/mY1zeNnFK

Another thing is, that noteheads aren't rendered in Chrome, nor in Nightly

notmasteryet commented 12 years ago

Could you check again if #1110 fixes that?

saebekassebil commented 12 years ago

It doesn't, sorry.

notmasteryet commented 12 years ago

The issue fixed by #1244

saebekassebil commented 12 years ago

Indeed fixed, thanks!