search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
48.77k stars 10.03k forks source link

pdf.js should set a favicon #1414

Closed ssokolow closed 10 years ago

ssokolow commented 12 years ago

With the increasing emphasis on favicons in modern browsers (and the fact that people like me write and use XUL userstyles to allow tabs to shrink to nothing but an icon), it gets a bit bothersome to have to pause to remember which dotted outline was the desired PDF and which was just a blog, piece of groupware, or government site that didn't set a default favicon.

(At this very moment, just in the current tab group, I've got two blog posts, a government website, two PDFs, and one of my own freshly-started creations presenting dotted outlines for icons)

I think pdf.js should, at least, set a favicon that can intutively be recognized as "PDF". (Preferrably not in a way specific to the extension, since that would work against making a good first impression.)

Snuffleupagus commented 10 years ago

This was also proposed in #2302, and #2329 contained a suggested implementation. Please note that the developers decided against implementing this, see: https://github.com/mozilla/pdf.js/pull/2329#issuecomment-9912081 and https://github.com/mozilla/pdf.js/pull/2329#issuecomment-9912103. Closing as won't fix.