mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
48.52k stars 9.98k forks source link

. #1814

Closed GHANONTEST closed 11 years ago

GHANONTEST commented 12 years ago

.

yurydelendik commented 12 years ago

See issues #1511, #1520 and #773 discussions

saebekassebil commented 12 years ago

node make chrome - This should build the chrome extension into the build folder (build/chrome/), and there from you can install the chrome extension from Chrome with Menu -> Extensions -> Load unpackaged extension. But no ready-made CRX I'm afraid

yurydelendik commented 12 years ago

Changing title to show the real topic (description was edited as well)

saebekassebil commented 12 years ago

I'm afraid the current Chrome Extension doesn't work that well, so until that's fixed there's no real reason in making a build script for assembling a CRX package.

brendandahl commented 12 years ago

@GHANONTEST I'm not aware of anyone currently working on the chrome extension version. We'd gladly take pull requests improving it though.

brendandahl commented 12 years ago

There's no barrier, except for maybe not enough hours in the day. The mozilla devs main focus is working on firefox integration and improving pdf feature support (which is more than enough work already). Like I said above, we'd be happy to review code that improves the chrome extension though.

saebekassebil commented 12 years ago

The internals of Chrome and Firefox and how they manage their extensions are quite different, yes. There's however not that much code which is actually platform-specific, as the team is striving to use cross-platform web standards that most modern browsers support.

But, the problem is: At the time of writing, the Chrome extension code isn't working properly, so there would be no idea in making a "readymade" CRX extension available.

saebekassebil commented 12 years ago

@GHANONTEST Well, I actually tested the Chrome extension yesterday, and it worked pretty great, besides that the URL/address bar is empty (#1511) which is a pretty big usability failure. Alas it is not really possible to do anything about it due to Chrome bug #72021 which states that chrome-extension:// urls doesn't get shown in the URL bar. I do however not see that anything catastrophic should happen, if one uses the Chrome extension, and therefore it's quite possible that the CRX build ought to be supported. Since a CRX is just a zip file this shouldn't be any problem and I'll be glad to look into it if you don't have the time.

saebekassebil commented 12 years ago

Uh, I'm afraid I just learned that a CRX extension is in fact not just a .zip file, but a sort of "signed" zip file with a special header: http://code.google.com/chrome/extensions/packaging.html

It shouldn't be any problem to implement that special packaging, but I don't think that it makes any sense that each developer create their own "unique" extension with PEM keys just to pack it. This should probably be done by the bot, the same way it happens for the .xpi Firefox extension.

@brendandahl: Packaging looks pretty easy, either we'd use chrome to pack it:

chrome.exe --pack-extension=c:\myext --pack-extension-key=c:\myext.pem

or we could do it internally (Here's an example). Is the bot closed-source or could I submit a PR to it?

brendandahl commented 12 years ago

@saebekassebil The bot is open source too, for the pdfjs stuff see https://github.com/mozilla/botio-files-pdfjs .

timvandermeij commented 11 years ago

@yurydelendik @brendandahl Can we close this? There is no title or issue body, so I don't know what the issue is anymore.