mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

47.23k stars 9.83k forks source link

Move the dialog css stuff in its own file #18174

Closed calixteman closed 1 month ago

calixteman commented 1 month ago

In order to share common parts between different dialogs, this patch aims to slightly refactor the css in making it more generic. This way it'll simplify adding a new dialog (we want to add a new one when leaving an unsaved document).

Snuffleupagus commented 1 month ago

/botio-linux preview

moz-tools-bot commented 1 month ago

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c46d98790d2e1e6/output.txt

moz-tools-bot commented 1 month ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c46d98790d2e1e6/output.txt

Total script time: 1.17 mins

Published

Viewer: http://54.241.84.105:8877/c46d98790d2e1e6/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/c46d98790d2e1e6/legacy/web/viewer.html

calixteman commented 1 month ago

Perhaps, in a follow-up, we should also use these CSS rules for the other dialogs as well (e.g. PasswordPrompt and PDFDocumentProperties)?

r=me, thanks!

Yep I thought about that too. If you want to make the follow-up, please do else I'll do it later in the week.