search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
48.17k stars 9.95k forks source link

Fix decoding of JPX images having an alpha channel #18204

Closed calixteman closed 4 months ago

calixteman commented 4 months ago

When an image has a non-zero SMaskInData it means that the image has an alpha channel. With JPX images, the colorspace isn't required (by spec) so when we don't have it, the JPX decoder will handle the conversion in RGBA format.

calixteman commented 4 months ago

/botio test

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d0917ce728a316f/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6e11bb66521501b/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/d0917ce728a316f/output.txt

Total script time: 28.29 mins

  different ref/snapshot: 24
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/d0917ce728a316f/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6e11bb66521501b/output.txt

Total script time: 43.58 mins

  different ref/snapshot: 10

Image differences available at: http://54.193.163.58:8877/6e11bb66521501b/reftest-analyzer.html#web=eq.log

calixteman commented 4 months ago

/botio test

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/359d4e88db737e0/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a963b4b79f4a32f/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/359d4e88db737e0/output.txt

Total script time: 28.02 mins

  different ref/snapshot: 23
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/359d4e88db737e0/reftest-analyzer.html#web=eq.log

timvandermeij commented 4 months ago

I think there a regression in issue11004-page1 and issue12579-page3 since they don't render anymore in the reference tests. Given that the earlier test run didn't seem to have it, it looks like the new changes changed the behavior; I've provided more information in the comment below.

With that addressed this patch also LGTM; thank you for fixing this issue!

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a963b4b79f4a32f/output.txt

Total script time: 43.25 mins

  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/a963b4b79f4a32f/reftest-analyzer.html#web=eq.log

calixteman commented 4 months ago

/botio test

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/431f00638cfc18a/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e79df2894c62088/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/431f00638cfc18a/output.txt

Total script time: 28.14 mins

  different ref/snapshot: 19
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/431f00638cfc18a/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e79df2894c62088/output.txt

Total script time: 42.91 mins

  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/e79df2894c62088/reftest-analyzer.html#web=eq.log

calixteman commented 4 months ago

/botio makeref

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fe3c6903b42bbf3/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0d236a4599ad1ad/output.txt

moz-tools-bot commented 4 months ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fe3c6903b42bbf3/output.txt

Total script time: 19.32 mins

moz-tools-bot commented 4 months ago

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/0d236a4599ad1ad/output.txt

Total script time: 24.15 mins