mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

47.17k stars 9.82k forks source link

Change `DownloadManager.download` to use Uint8Array-data #18216

Closed Snuffleupagus closed 4 weeks ago

Snuffleupagus commented 4 weeks ago

Part of this code is really old and pre-dates general availability of things such as Blob and URL.createObjectURL. To avoid having to duplicate the Blob-creation in the viewer, we can move this into DownloadManager.download instead.

Also, remove a couple of unnecessary await statements since the methods in question are synchronous.

timvandermeij commented 4 weeks ago

/botio-linux preview

moz-tools-bot commented 4 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/510782efe85ffc4/output.txt

moz-tools-bot commented 4 weeks ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/510782efe85ffc4/output.txt

Total script time: 1.08 mins

Published

Viewer: http://54.241.84.105:8877/510782efe85ffc4/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/510782efe85ffc4/legacy/web/viewer.html

timvandermeij commented 4 weeks ago

Nice improvement; thanks!