search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.17k stars 9.82k forks source link

Remove the `DownloadManager.downloadUrl` method #18236

Closed Snuffleupagus closed 3 weeks ago

Snuffleupagus commented 3 weeks ago

This method has only a single call-site in the viewer, since it's used as a fallback, and the functionality can be moved into the DownloadManager.download method instead.

Snuffleupagus commented 3 weeks ago

/botio integrationtest

moz-tools-bot commented 3 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/09f030cce9c983a/output.txt

moz-tools-bot commented 3 weeks ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2721d88557f7f02/output.txt

moz-tools-bot commented 3 weeks ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/09f030cce9c983a/output.txt

Total script time: 7.66 mins

moz-tools-bot commented 3 weeks ago

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/2721d88557f7f02/output.txt

Total script time: 22.66 mins

timvandermeij commented 3 weeks ago

/botio-linux preview

moz-tools-bot commented 3 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bc4e600d8014282/output.txt

moz-tools-bot commented 3 weeks ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bc4e600d8014282/output.txt

Total script time: 1.09 mins

Published

timvandermeij commented 3 weeks ago

Thank you for simplifying this!