mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
48.14k stars 9.95k forks source link

Replace Wintersmith with Metalsmith #18248

Closed timvandermeij closed 3 months ago

timvandermeij commented 3 months ago

Wintersmith is no longer maintained given that the most recent version is from six years ago, and all vulnerabilities that NPM reports originate from Wintersmith's dependencies. Metalsmith, and its plugins, on the other hand have recently had releases and don't have known vulnerabilities. In fact, the number of reported vulnerabilities by NPM even goes down to zero with this patch applied.

This commit therefore replaces Wintersmith with Metalsmith by providing a transparent drop-in replacement, in a way that requires the least amount of changes to the code and the generated output.

Note that this patch does update our versions of jQuery, Bootstrap and the Highlight.js theme because the previous versions were very outdated and didn't work correctly with Metalsmith. Moreover, those old versions contained vulnerabilities that are hereby fixed.

Fixes #18198.

timvandermeij commented 3 months ago

/botio-linux preview

moz-tools-bot commented 3 months ago

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/683680ffc99851b/output.txt

moz-tools-bot commented 3 months ago

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/683680ffc99851b/output.txt

Total script time: 0.99 mins

Published

timvandermeij commented 3 months ago

Extra context for the reviewer: