Only disable HWA in m-c build and for local dev

mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

47.14k stars 9.82k forks source link

Only disable HWA in m-c build and for local dev #18255

Closed calixteman closed 2 weeks ago

calixteman commented 2 weeks ago

This way, we keep pdf.js working as before except for Firefox.

Snuffleupagus commented 2 weeks ago

Given that we've historically seen loads of bug reports for Chromium browsers where the issue goes away when HWA is disabled in the browser, do we actually want to make this change? It thus seem, unless I misunderstand things, that keeping the default value could help prevent many issues in Chromium browsers.

Rob--W commented 2 weeks ago

The context of this PR is the discussion starting at https://github.com/mozilla/pdf.js/pull/18238#issuecomment-2170640215

While disabling HWA is known to fix some bugs, the question is whether disabling it unconditionally is going to have a net positive effect.