mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

47.14k stars 9.82k forks source link

Ensure that dependencies are added to the operatorList for locally cached images (issue 18259) #18269

Closed Snuffleupagus closed 2 weeks ago

Snuffleupagus commented 2 weeks ago

/botio test

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6e0ea539a1a9e89/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c7c5f7714d511d0/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6e0ea539a1a9e89/output.txt

Total script time: 28.63 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 13
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/6e0ea539a1a9e89/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c7c5f7714d511d0/output.txt

Total script time: 44.11 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 3

Image differences available at: http://54.193.163.58:8877/c7c5f7714d511d0/reftest-analyzer.html#web=eq.log

Snuffleupagus commented 2 weeks ago

Missed one case...

/botio test

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4f8a8bd7a5fea7f/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/205590cf8f15436/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4f8a8bd7a5fea7f/output.txt

Total script time: 28.68 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 17
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/4f8a8bd7a5fea7f/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/205590cf8f15436/output.txt

Total script time: 42.02 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 9

Image differences available at: http://54.193.163.58:8877/205590cf8f15436/reftest-analyzer.html#web=eq.log

Snuffleupagus commented 2 weeks ago

Locally I get less "severe" movement when testing on Windows, perhaps this is worse with devicePixelRatio === 1 since I believe the bots use that? Perhaps the QueueOptimizer logic is also affecting things, now that we're correctly handling cached imageMask-data as well?

In any case, given that this patch ought to be correct are we OK with the ref-test movement in the latest round of testing?

timvandermeij commented 2 weeks ago

I have checked locally that this indeed solves the issue. I have also checked the last round of reference tests and didn't find anything that was either noticeable with the naked eye or that was unexpected movement, and given that I agree that this patch should be correct I think we can do this. Thanks!

timvandermeij commented 2 weeks ago

/botio makeref

moz-tools-bot commented 2 weeks ago