search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.14k stars 9.82k forks source link

[Editor] Remove the various listeners when destroying the editor manager #18284

Closed calixteman closed 1 week ago

calixteman commented 2 weeks ago

/botio integrationtest

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d7f0085ef166934/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ad44a079e71b15c/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d7f0085ef166934/output.txt

Total script time: 7.66 mins

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ad44a079e71b15c/output.txt

Total script time: 18.03 mins

Snuffleupagus commented 2 weeks ago

Maybe also change https://github.com/mozilla/pdf.js/blob/4b5d5a557c9177b93f15ceb77e3c1e9df7f8196f/src/display/editor/ink.js#L264 to this.#observer?.disconnect(); to avoid any future issue with ordering?

calixteman commented 2 weeks ago

/botio integrationtest

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1484e930beccdaf/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/658d976e3eb3373/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1484e930beccdaf/output.txt

Total script time: 7.63 mins

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/658d976e3eb3373/output.txt

Total script time: 18.00 mins

calixteman commented 2 weeks ago

/botio integrationtest

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f9ff688456dfe84/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9a977f5460c5b74/output.txt

moz-tools-bot commented 2 weeks ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f9ff688456dfe84/output.txt

Total script time: 7.70 mins

moz-tools-bot commented 2 weeks ago

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9a977f5460c5b74/output.txt

Total script time: 18.49 mins