search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.09k stars 9.81k forks source link

Update the regular expression in `tweakWebpackOutput` to support minified-legacy builds (issue 18290) #18292

Closed Snuffleupagus closed 1 week ago

Snuffleupagus commented 1 week ago

/botio test

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6390901190a62e4/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a46ca35c75c1e4f/output.txt

nicolo-ribaudo commented 1 week ago

Would be it be safer to have an AST-based transform?

Snuffleupagus commented 1 week ago

Would be it be safer to have an AST-based transform?

Of course, assuming that works. (I'm not sure if these webpack-structures are available during babel-plugin-pdfjs-preprocessor.mjs, or if those are added later on.)

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/6390901190a62e4/output.txt

Total script time: 28.49 mins

  different ref/snapshot: 20
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/6390901190a62e4/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a46ca35c75c1e4f/output.txt

Total script time: 44.40 mins

  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/a46ca35c75c1e4f/reftest-analyzer.html#web=eq.log

timvandermeij commented 1 week ago

Thanks! For now this fixes the issue and the code is shorter, and if it can later be moved to an AST transform that'd be even better.