mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

47.09k stars 9.81k forks source link

[Editor] Don't create an observer for the stamp annotation after the viewer has been closed #18301

Closed calixteman closed 1 week ago

calixteman commented 1 week ago

When running tests in PR #18296, I noticed this error:

JavaScript error: http://127.0.0.1:59398/build/generic/build/pdf.mjs, line 18783: TypeError: can't access property "addEventListener", this._uiManager._signal is null

so this patch should fix it.

calixteman commented 1 week ago

/botio integrationtest

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0279385b058bc80/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/91c40554d1b07c0/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0279385b058bc80/output.txt

Total script time: 7.92 mins

Integration Tests: Passed

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/91c40554d1b07c0/output.txt

Total script time: 18.62 mins

Integration Tests: Passed