search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.09k stars 9.81k forks source link

Close `PDFFindBar` when closing the viewer during testing #18302

Closed Snuffleupagus closed 1 week ago

Snuffleupagus commented 1 week ago

By closing PDFFindBar we also disconnect the ResizeObserver, since we've seen at least one case where that's running during shutdown: http://54.193.163.58:8877/91c40554d1b07c0/output.txt

timvandermeij commented 1 week ago

/botio integrationtest

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4689d41f074e664/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/091d6681722c655/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4689d41f074e664/output.txt

Total script time: 7.73 mins

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/091d6681722c655/output.txt

Total script time: 19.04 mins

timvandermeij commented 1 week ago

Thank you for fixing this one!