mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.09k stars 9.81k forks source link

Expose entireWord in updateFindControlState #18303

Closed bootleq closed 1 week ago

bootleq commented 1 week ago

This is a request to additionally expose entireWord state in updateFindControlState.

Have a use case

I am studying Firefox findbar behavior when viewing PDF, especially the "not found" sound. The condition of the sound requires to consider whether entireWord is checked. See related implementation in https://hg.mozilla.org/mozilla-central/rev/16b902cbcf26

This PR would help if I move the implementation from cpp to jsm.

Snuffleupagus commented 1 week ago

/botio test

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/13a29b0a0c35890/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/959293c25a66bbf/output.txt

moz-tools-bot commented 1 week ago

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/959293c25a66bbf/output.txt

Total script time: 28.72 mins

  different ref/snapshot: 14
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/959293c25a66bbf/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 1 week ago

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/13a29b0a0c35890/output.txt

Total script time: 44.18 mins

  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/13a29b0a0c35890/reftest-analyzer.html#web=eq.log

Snuffleupagus commented 1 week ago

Please squash the commits, since we don't use separate fixup commits in this project.

timvandermeij commented 1 week ago

Looks good to me too, especially with the added test. Thank you!