mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.09k stars 9.81k forks source link

Use `waitForEvent` in the `pasteFromClipboard` integration test helper function #18326

Closed timvandermeij closed 5 days ago

timvandermeij commented 6 days ago

This code contains the same bug that the previous commit fixed in waitForEvent, namely that we don't clear the timeout if the event is triggered. By using the now fixed waitForEvent function we not only deduplicate this code but we also fix this issue so that no incorrect timeout logs show up anymore.

Note that this patch gets rid of the incorrect timeout logs, but this doesn't solve the problem of the correct timeout logs yet (but it's preparatory work for follow-up patches that address that problem).

Fixes a part of #17931.

timvandermeij commented 6 days ago

/botio integrationtest

moz-tools-bot commented 6 days ago

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8a3d2f22102b7c6/output.txt

moz-tools-bot commented 6 days ago

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/02d98f9c7934571/output.txt

moz-tools-bot commented 6 days ago

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/02d98f9c7934571/output.txt

Total script time: 8.12 mins

moz-tools-bot commented 6 days ago

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/8a3d2f22102b7c6/output.txt

Total script time: 19.03 mins