mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

47.09k stars 9.81k forks source link

Cancel the `requestAnimationFrame` in the `watchScroll` helper (PR 18193 follow-up) #18335

Closed Snuffleupagus closed 4 days ago

Snuffleupagus commented 4 days ago

While the event listener is removed during testing, the requestAnimationFrame isn't cancelled and that occasionally shows up when the integration-tests are run on the bots.

Snuffleupagus commented 4 days ago

/botio integrationtest

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/09f092a9e2dcb47/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/879fbee00857f38/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/879fbee00857f38/output.txt

Total script time: 7.76 mins

Integration Tests: Passed

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/09f092a9e2dcb47/output.txt

Total script time: 18.85 mins

Integration Tests: FAILED

timvandermeij commented 4 days ago

Looks good; thanks!