mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
47.09k stars 9.81k forks source link

Cancel the `requestAnimationFrame` in the API when cancelling rendering #18336

Closed Snuffleupagus closed 3 days ago

Snuffleupagus commented 4 days ago

Errors related to this requestAnimationFrame show up intermittently when running the integration-tests on the bots, however I've been unable to reproduce it locally. Hence I cannot guarantee that it's enough to fix the timing issues, however this should be generally safe since the requestAnimationFrame invokes the _next-method and the first thing that one does is check that rendering hasn't been cancelled.

Snuffleupagus commented 4 days ago

/botio test

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/26fa00f82e26d69/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b37b4878b6f1283/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/26fa00f82e26d69/output.txt

Total script time: 28.80 mins

  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/26fa00f82e26d69/reftest-analyzer.html#web=eq.log

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/b37b4878b6f1283/output.txt

Total script time: 42.83 mins

  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/b37b4878b6f1283/reftest-analyzer.html#web=eq.log

Snuffleupagus commented 4 days ago

/botio integrationtest

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a26ff72afafb4c6/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d31191e5350de57/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/a26ff72afafb4c6/output.txt

Total script time: 8.14 mins

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d31191e5350de57/output.txt

Total script time: 18.69 mins

Snuffleupagus commented 4 days ago

/botio integrationtest

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d47fc26c7be7e7f/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a7d085828ebdfaa/output.txt

moz-tools-bot commented 4 days ago

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a7d085828ebdfaa/output.txt

Total script time: 8.18 mins

moz-tools-bot commented 4 days ago

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d47fc26c7be7e7f/output.txt

Total script time: 17.04 mins

timvandermeij commented 3 days ago

Thanks!