mozilla / pdf.js

PDF Reader in JavaScript

https://mozilla.github.io/pdf.js/

Apache License 2.0

48.17k stars 9.95k forks source link

Group and scope the findbar rules using CSS nesting #18568

Closed timvandermeij closed 1 month ago

timvandermeij commented 2 months ago

The findbar CSS rules predate the general availability of CSS nesting, which makes them more difficult to understand and change safely. The primary issues are that the findbar rules are spread all over the viewer.css file, they share blocks with non-findbar elements and the scope of the rules is sometimes bigger than necessary.

This refactoring groups all findbar-related CSS rules together, scoped to the top-level #findbar element, for improved overview and isolation. Note that this patch only intends to move the existing rules around and not change any behavior yet, but it does lay the foundation for e.g. making the findbar respect the browser.uidensity preference in Firefox in follow-up work.

Notes for the reviewer:

I have deliberately introduced the #findbar rules in a different part of the file to make the diff easier. Now the deletions and additions can more easily be compared side-by-side while otherwise they would be intertwined.
The rules at https://github.com/mozilla/pdf.js/pull/18568/files#diff-d1047e1376717fbe7c554bb385cd48b2dcbbb135e02884be3db97ad072ba741eL365 were all overridden by either https://github.com/mozilla/pdf.js/pull/18568/files#diff-d1047e1376717fbe7c554bb385cd48b2dcbbb135e02884be3db97ad072ba741eL451 or the doorhanger class, and as such could simply be removed. This can be confirmed by opening the default viewer, inspecting the #findbar element and noticing that the rules in this block are already inactive:

The other rules have been moved as-is, but only placed in alphabetical order in the new blocks for increased readability.

Extracts a part of #18385.

timvandermeij commented 2 months ago

/botio-linux preview

moz-tools-bot commented 2 months ago

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8ad2c1f7d669cf4/output.txt

moz-tools-bot commented 2 months ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8ad2c1f7d669cf4/output.txt

Total script time: 1.03 mins

Published

Viewer: http://54.241.84.105:8877/8ad2c1f7d669cf4/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/8ad2c1f7d669cf4/legacy/web/viewer.html

timvandermeij commented 2 months ago

/botio integrationtest

moz-tools-bot commented 2 months ago

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a99fa62fe79c1ac/output.txt

moz-tools-bot commented 2 months ago

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ffc9debbfff0603/output.txt

moz-tools-bot commented 2 months ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a99fa62fe79c1ac/output.txt

Total script time: 8.49 mins

Integration Tests: Passed

moz-tools-bot commented 2 months ago

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/ffc9debbfff0603/output.txt

Total script time: 19.05 mins

Integration Tests: Passed

timvandermeij commented 1 month ago

/botio-linux preview

moz-tools-bot commented 1 month ago

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c5133c705aaff0e/output.txt

moz-tools-bot commented 1 month ago

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c5133c705aaff0e/output.txt

Total script time: 1.03 mins

Published

Viewer: http://54.241.84.105:8877/c5133c705aaff0e/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/c5133c705aaff0e/legacy/web/viewer.html