search

mozilla / pdf.js

PDF Reader in JavaScript
https://mozilla.github.io/pdf.js/
Apache License 2.0
48.31k stars 9.97k forks source link

no loading bar / sign while rendering pdf #494

Closed yudhis closed 13 years ago

yudhis commented 13 years ago

Loading sign or bar (in percentage) is important to give information to user if the requsted page is on process. It can increase user experience.

yudhis commented 13 years ago

also if user disable javascript.

joneschrisg commented 13 years ago

Quick question: is there a PDF you started loading in pdf.js that took so long to display that you wanted some sort of "loading" indicator? If so, which PDF was it, at which URL?

There are some fundamental network limitations that prevent pdf.js from quickly loading all PDFs in general, and for those a load indicator makes sense. But if network isn't an issue for a particular PDF, and there's something slow in pdf.js that delays displaying the PDF, we would want to fix that bug in pdf.js.

yudhis commented 13 years ago

Hi !

Thanks for quick response :)

I didnt say that pdf.js i slow. I am pointing to the user whose has slow connection speed.

if you live in US, your internet speed has no problem in processing any size of pdf files. But, how about user who live in Indonesia like me? with slow connection (avg. 384 kbps or slower, dooh!) and read pdf file which size is 30 MB or bigger? It take some time time before all pages rendered properly.

Loading indicator will make sense and important to increase user experience. it gives information that page is still on process and ask user to wait, otherwise, they think that page encounter an error and close the browser.

in my opinion, the best way to implement loading indicator is on first load and every single page load.

Btw, I try to implement pdfjs on my startup: www.pdfpedia.com (pdf file sharing website) Have a look in this sample: http://www.pdfpedia.com/read/5071/halloween-fun-recipes-party-games-pdf.html

I am planning to publish this full document reading feature (which powered by pdfjs) soon.

Thanks for developing great things!

Yudhis

vingtetun commented 13 years ago

I'm totally in favor of a loading indicator. Sometimes I'm opening some PDF's files of ~15Mb and since nothing is displayed at this point I don't know if the document has failed to load or if it is downloading. I'm living in France and I have a pretty decent connection.

yudhis commented 13 years ago

Yeah! i have the same experience with vingtetun. There should be an indicator if a document on load or failed to load :)

joneschrisg commented 13 years ago

We definitely need better error reporting. That might fit well with the other work in #74.

But the case of having to download a 15MB PDF before displaying anything is a good example of what I had in mind: the reason pdf.js has to do that is because we don't have support for streaming XHR or HTTP byte-range requests. If we did, we could display the first page after having downloaded far less data, most of the time.

But again, a load indicator is a good idea anyway for when we're on a slow network :). I don't disagree with that.

yudhis commented 13 years ago

Hi,

My friend make this simple loading indicator.

Check this sample: http://www.pdfpedia.com/read/910/twitter-ebook-pdf.html

Cheers

vingtetun commented 13 years ago

cool, do you mind doing a pull request, so we could land onto the main branch it if the code is fine :)

yudhis commented 13 years ago

of course. i would like to ask my friend swznd.

He code that.

yudhis commented 13 years ago

check here: https://github.com/andreasgal/pdf.js/pull/505

vingtetun commented 13 years ago

Fixed by #505