Closed julienw closed 9 months ago
Name | Link |
---|---|
Latest commit | 1f79b48b42cbf1f50084d48d0a47049ff380540d |
Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/65a50667cdc58a000878f500 |
Deploy Preview | https://deploy-preview-587--mozilla-perfcompare.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3d0654a
) 99.34% compared to head (1f79b48
) 99.34%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before this patch, we have 2 different render functions:
render
andrenderWithRouter
. We also have aStoreProvider
that's justreact-redux
'sProvider
pre-configured, that we use in some hooks-related test files.The 2 render functions are "created" in
beforeEach
and exposed bysetupTests
. Instead of "creating" them, in this patch they're now defined directly, and they can be imported directly fromtest-utils
in the test files. The goal is that it's now easier to create new flavors for these functions, that I'd like to use in #582.The
store
object is imported fromsetupTests
instead of being passed as a parameter. I considered creating it in therender
functions (possibly as a default parameter, so that we could pass another store if needed) and returning it, but this would require changing all call sites, so I decided to keep it simple for now. We could always change it more later.This is on top of #584 and #586 to minimize rebase conflicts, so take care to only look at the few un-labeled commits at the end of the commit list.