Closed Carla-Moz closed 8 months ago
Name | Link |
---|---|
Latest commit | 0e52002fbc91ad8b12f307697a2bcacf8e03c127 |
Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/65b3f3abfdea340008fe6b3d |
Deploy Preview | https://deploy-preview-595--mozilla-perfcompare.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
1f35038
) 99.34% compared to head (a765ec1
) 99.35%. Report is 3 commits behind head on beta.:exclamation: Current head a765ec1 differs from pull request most recent head e486763. Consider uploading reports for the commit e486763 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR closes the following Jira issues:
PCF-318 In Results view, on edit, the results get appended to the old results instead of replacing them
PCF-354 Results: The revision(s) need(s) to be preselected in edit mode search dropdown for both base and new revisions
PCF-356 Results: in edit mode, clicking the cancel button doesn't return to default state after deleting revision(s)
PCF-357 Results: in edit mode, clicking the save button does not update the state of the revisions correctly
Please look at this commit - e2e2d46 for relevant changes
The relevant files to look at for this review:
This review implements the "staging", "in progress", and "committed" states of the edit feature where the
CompareWithBase
handles the state of the selected revisions "in staging" and "in progress". Please look at the comments on this closed PR for reference: https://github.com/mozilla/perfcompare/pull/581Tests and coverage will be handled in a separate PR.