mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Edit revision clean 2 #595

Closed Carla-Moz closed 8 months ago

Carla-Moz commented 9 months ago

This PR closes the following Jira issues:

Please look at this commit - e2e2d46 for relevant changes

The relevant files to look at for this review:

src/components/Search/CompareWithBase.tsx
src/components/Search/SearchComponent.tsx
src/components/Search/EditButton.tsx
src/components/Search/SaveCancelButtons.tsx
src/components/Search/SearchResultsList.tsx
src/components/Search/SearchResultsListItem.tsx
src/components/Search/SelectedRevisions.tsx
src/components/Search/SelectedRevisionItem.tsx

src/hooks/useCheckRevision.ts
src/hooks/useSelectedRevisions.ts

src/reducers/SelectedRevisionsSlice.ts

This review implements the "staging", "in progress", and "committed" states of the edit feature where the CompareWithBase handles the state of the selected revisions "in staging" and "in progress". Please look at the comments on this closed PR for reference: https://github.com/mozilla/perfcompare/pull/581

Tests and coverage will be handled in a separate PR.

netlify[bot] commented 9 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 0e52002fbc91ad8b12f307697a2bcacf8e03c127
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65b3f3abfdea340008fe6b3d
Deploy Preview https://deploy-preview-595--mozilla-perfcompare.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1f35038) 99.34% compared to head (a765ec1) 99.35%. Report is 3 commits behind head on beta.

:exclamation: Current head a765ec1 differs from pull request most recent head e486763. Consider uploading reports for the commit e486763 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #595 +/- ## ======================================== Coverage 99.34% 99.35% ======================================== Files 62 55 -7 Lines 1366 1077 -289 Branches 189 149 -40 ======================================== - Hits 1357 1070 -287 + Misses 9 7 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.