search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Edit Review Clean - 3 #599

Closed Carla-Moz closed 8 months ago

Carla-Moz commented 8 months ago

Resolves the comments to simplify the child components with simple callbacks rather than state setters. See here Squashed commits - cleaner history

netlify[bot] commented 8 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 05d5fa32913a68a990f5e26b5986b014c6eb56c8
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65b83aa3a1dde50008cc775c
Deploy Preview https://deploy-preview-599--mozilla-perfcompare.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (67bf4e2) 99.21% compared to head (05d5fa3) 96.69%.

Files Patch % Lines
src/components/Search/CompareWithBase.tsx 65.82% 21 Missing and 6 partials :warning:
src/components/Search/SearchComponent.tsx 71.42% 2 Missing and 6 partials :warning:
src/components/Search/SearchResultsList.tsx 86.66% 2 Missing :warning:
src/hooks/useCheckRevision.ts 88.88% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #599 +/- ## ========================================== - Coverage 99.21% 96.69% -2.52% ========================================== Files 63 63 Lines 1402 1453 +51 Branches 190 224 +34 ========================================== + Hits 1391 1405 +14 - Misses 10 35 +25 - Partials 1 13 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.