mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Add an Error Boundary for the results page, and add more tests around the react router behavior #600

Closed julienw closed 8 months ago

julienw commented 8 months ago

Please look only at the last commits that are not prefixed with a mention.

The 2 first commits are preparatory to the Error Boundary component. They make it easier to have a similar visual design. Commit 3 adds a simple error boundary and configures it with the router. Commit 4 adds new tests for the router and the error boundary.

Most of the remaining missing coverage will be covered when I'll work on fetching the recent revisions using the react router, that's why I didn't cover them here.

You can test the error boundary by requesting with wrong parameters, for example:

netlify[bot] commented 8 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 43f6dc93354d059f8174774006549c7047afc347
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65b93829bb203b000963eaa4
Deploy Preview https://deploy-preview-600--mozilla-perfcompare.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a552110) 92.54% compared to head (43f6dc9) 93.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #600 +/- ## ========================================== + Coverage 92.54% 93.63% +1.09% ========================================== Files 62 64 +2 Lines 1395 1414 +19 Branches 217 219 +2 ========================================== + Hits 1291 1324 +33 + Misses 100 88 -12 + Partials 4 2 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.