search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Simplify callbacks in Compare With Base child comps #601

Closed Carla-Moz closed 8 months ago

Carla-Moz commented 8 months ago

@julienw, I kept the isBaseComp for styling reasons. Otherwise, it's removed from any state updates. In a new patch, I'll redo the styles so we can eliminate the prop completely.

netlify[bot] commented 8 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 7a7236a1c6d2f8a72a7470c3a1d5392ea68b5ed1
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65b84a7cfe916a00085653b2
Deploy Preview https://deploy-preview-601--mozilla-perfcompare.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (817f5c3) 96.69% compared to head (7a7236a) 97.21%.

Files Patch % Lines
src/components/Search/CompareWithBase.tsx 52.38% 20 Missing :warning:
src/components/Search/SearchComponent.tsx 40.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #601 +/- ## ========================================== + Coverage 96.69% 97.21% +0.51% ========================================== Files 63 63 Lines 1453 1437 -16 Branches 224 203 -21 ========================================== - Hits 1405 1397 -8 - Misses 35 39 +4 + Partials 13 1 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.