mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Add some focus outlines #605

Closed julienw closed 7 months ago

julienw commented 7 months ago

Fixes https://mozilla-hub.atlassian.net/browse/PCF-376

This adds a focus outline to:

I found that the other elements had a focus style already.

image image image

I didn't do a different thing for the dark theme. As a result the color is different than other focus outlines. I couldn't find where the focus outline for the hash/email TextField is defined to be honest...

netlify[bot] commented 7 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 77b07acf6aaffa4513a805bee687accb745d9f03
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65d603bc80090b000828a8b0
Deploy Preview https://deploy-preview-605--mozilla-perfcompare.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e09c728) 93.63% compared to head (c2d2b27) 93.63%. Report is 1 commits behind head on beta.

:exclamation: Current head c2d2b27 differs from pull request most recent head 77b07ac. Consider uploading reports for the commit 77b07ac to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #605 +/- ## ========================================== - Coverage 93.63% 93.63% -0.01% ========================================== Files 64 64 Lines 1415 1414 -1 Branches 219 219 ========================================== - Hits 1325 1324 -1 Misses 88 88 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.