search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

updated tests and added coverage for edit feature #608

Closed Carla-Moz closed 7 months ago

Carla-Moz commented 7 months ago

This PR resolves the following issues:

netlify[bot] commented 7 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit cdde0d114fc89384f3efd5e8bfe336337a3fe1fa
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65e6202072a31a00081fa263
Deploy Preview https://deploy-preview-608--mozilla-perfcompare.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.87%. Comparing base (8cabf8c) to head (cdde0d1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #608 +/- ## ========================================== + Coverage 93.67% 97.87% +4.20% ========================================== Files 64 64 Lines 1422 1410 -12 Branches 223 219 -4 ========================================== + Hits 1332 1380 +48 + Misses 88 28 -60 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Carla-Moz commented 7 months ago

Therefore I would suggest to add a aria-label (maybe aria-label="Compare with base" is good enough) instead of a role. What do you think?

@julienw This seems like a good solution to me, esp since I'm working on the Compare over timecomponent. It makes sense to differentiate between the two.