mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Compare over time default state #616

Closed Carla-Moz closed 6 months ago

Carla-Moz commented 7 months ago

This PR begins the work on the Compare over Time component reflected in this ticket: Search: Add component for Compare over time

Right now it covers only the first two checkboxes below. The component is hidden until all work is completed. Please add the #comparetime to the path to see and test it. Please let me know if there's anything I can add to make reviewing this simpler.

netlify[bot] commented 7 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit dcc466daae3d8fff9d112ab177abe6dcf04032c8
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65fb37ebfed0490008e49536
Deploy Preview https://deploy-preview-616--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 98.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.82%. Comparing base (3714be8) to head (dcc466d).

Files Patch % Lines
src/components/Search/SearchOverTime.tsx 97.82% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #616 +/- ## ========================================== - Coverage 98.84% 98.82% -0.02% ========================================== Files 63 64 +1 Lines 1383 1452 +69 Branches 215 230 +15 ========================================== + Hits 1367 1435 +68 - Misses 14 15 +1 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Carla-Moz commented 6 months ago

@julienw, please review the changes. I'll handle the style overrides refactor in a separate PR. Thanks for your review!!