Rename RevisionsList to Changeset

julienw commented 7 months ago

This was confusing me a lot. Indeed in the code base, the term "revisionsList" was used for both a Changeset and a list of Changesets (RevisionsList[]). So I think the term Changeset is more idiomatic. This is how Firefox developers call this object. For example on hg.mozilla.org: https://hg.mozilla.org/mozilla-central/pushloghtml or https://hg.mozilla.org/integration/autoland/rev/64e14543839c59fc9fc3d71a1cc60507bb9c7064 Note that 64e... is the changeset's revision, so it's exactly the same object we have here.

netlify[bot] commented 7 months ago

Deploy Preview for mozilla-perfcompare ready!

Name	Link
Latest commit	962ffeb0d795376bb84cee3b870ad904e46fbe96
Latest deploy log	https://app.netlify.com/sites/mozilla-perfcompare/deploys/65eb45d55d9c2d00084defcc
Deploy Preview	https://deploy-preview-617--mozilla-perfcompare.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.87%. Comparing base (8e62e81) to head (962ffeb).

Files	Patch %	Lines
src/hooks/useSelectedRevisions.ts	0.00%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## beta #617 +/- ## ========================================== - Coverage 97.87% 97.87% -0.01% ========================================== Files 64 64 Lines 1410 1409 -1 Branches 219 219 ========================================== - Hits 1380 1379 -1 Misses 28 28 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

julienw commented 7 months ago

thanks for the review!

mozilla / perfcompare