search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Simplify SelectedRevisions component by moving up the decision of displaying the remove button #623

Closed julienw closed 7 months ago

julienw commented 7 months ago

This is a similar idea than #622: this makes SelectedRevisions to take a prop that's directly tied to its rendering rather than reacting on some more high-level state.

In the future, when I'll remove some more code from this component, and that will make it possible to remove the prop hasNonEditableState as well. But we're not there yet.

I also removed the icon className because I found it's not used, but tell me if you'd prefer that I keep it. That's where the snapshot changes come from.

netlify[bot] commented 7 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 54357348ce371a2442266a1adb21119ea63e0903
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65f9a1acc99151000810bf25
Deploy Preview https://deploy-preview-623--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.84%. Comparing base (83eef61) to head (5435734).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #623 +/- ## ======================================= Coverage 98.84% 98.84% ======================================= Files 63 63 Lines 1387 1388 +1 Branches 214 215 +1 ======================================= + Hits 1371 1372 +1 Misses 14 14 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.