search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Rename most callback props used in CompareWithBase so that they look like events #624

Closed julienw closed 7 months ago

julienw commented 7 months ago

This is another quite cosmetic PR!

This mostly changes how some props that take callbacks are called. There are several goals:

  1. more consistent naming across components, especially for the "onRemoveRevision" callback
  2. make clear what we consider as being "events" (eg: toggle, edit, etc)
netlify[bot] commented 7 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 5a02e534c030c42b932d90967786a4739dcce982
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/65f9a2c77aeb840008d8944f
Deploy Preview https://deploy-preview-624--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.84%. Comparing base (6c0c01d) to head (5a02e53).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #624 +/- ## ========================================== - Coverage 98.84% 98.84% -0.01% ========================================== Files 63 63 Lines 1388 1383 -5 Branches 215 215 ========================================== - Hits 1372 1367 -5 Misses 14 14 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.