mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Move the repository information from Redux to a local state in CompareWithBase #633

Closed julienw closed 6 months ago

julienw commented 6 months ago

The goal is to make SearchContainer and all other components in the tree more self-contained that they were before.

This also moves SearchViewInit to CompareWithBase. But this is only temporary because this component will be removed later.

netlify[bot] commented 6 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit b39abcf617c913d0852a35a824f24a6cc2edd6cd
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66141a7b758c2600082c4d6e
Deploy Preview https://deploy-preview-633--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.68%. Comparing base (1c8763e) to head (b39abcf).

Files Patch % Lines
src/components/Search/SearchOverTime.tsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #633 +/- ## ========================================== - Coverage 98.76% 98.68% -0.09% ========================================== Files 63 63 Lines 1381 1372 -9 Branches 217 217 ========================================== - Hits 1364 1354 -10 - Misses 15 16 +1 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

julienw commented 6 months ago

Rebased on top of latest beta branch!