netlify[bot]
commented
6 months ago Deploy Preview for mozilla-perfcompare ready!
| Name | Link |
|---|---|
| Latest commit | 91801b929b9afa8bc6ed0132ea6c5ca0cc3d7fb7 |
| Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/66154a4058702400085a29e8 |
| Deploy Preview | https://deploy-preview-635--mozilla-perfcompare.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
codecov[bot]
Extracting these 2 components into a separate comment makes sense in terms of component responsibilities. Indeed the SearchInput controls its Dropdown. Using a component to contain both makes it possible for this component to keep all the necessary state to control this behavior This is also common code for both
SearchOverTimeandSearchView, so it makes sense to extract it.Please look at the two last commits only. Commit 1: this extracts the common code to a separate component Commit 2: this changes this component to make it more generic, so that it works the same for both CompareWithBase and CompareOverTime, without relying on class names. There are a bunch of snapshot changes because this adds a new container to the pair
SearchInput/SearchResultsList, if you look at them by disabling whitespace changes it is much easier to see these changes.