Closed Carla-Moz closed 5 months ago
Name | Link |
---|---|
Latest commit | 936c88e4b196f817fbbb9097d485873dcbd5dce9 |
Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/66342b09624d6d0008507398 |
Deploy Preview | https://deploy-preview-640--mozilla-perfcompare.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.88%. Comparing base (
7e0f0bc
) to head (936c88e
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Side note: I talked to Dasha about toggling the display of the "Compare with Base" and "Compare Over time" component in which clicking on one hides the content below their respective headers so they function like radio buttons. This is not handled in this PR but something I think would be helpful to do in a future PR.
Yeah I don't like the current situation much either, happy to improve it in any way.
This PR fulfills the requirements of Handle checked and displayed selected revisions. This is the last remaining part of the Compare over time component. The hash to hide it is removed. The "Compare" button will remain disabled (see this commit) until the next PR to add react-router config to fetch the data.
New File Created: In this commit, I created a new file called
useSearchResults
because both the Revisions component in "With base" and "Overtime" handle the search results toggle the same way, including showing the error when the user attempts to select more than 3 revisions. This required updating theCompareWithBase
file.Style Tweaks: In this commit, I did a small update on
styles/SearchContainerStyles
andstyles/Documents
to better reflect the overflow of the search results dropdown.Update test coverage in
CompareOvertTime.test:
please check this commit.Side note: I talked to Dasha about toggling the display of the "Compare with Base" and "Compare Over time" component in which clicking on one hides the content below their respective headers so they function like radio buttons. This is not handled in this PR but something I think would be helpful to do in a future PR.