Closed Carla-Moz closed 4 months ago
Name | Link |
---|---|
Latest commit | 79cf17bfd00af56fb298303b4845c3f3ae72871e |
Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/664bf07899c6d50008534525 |
Deploy Preview | https://deploy-preview-650--mozilla-perfcompare.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Attention: Patch coverage is 34.00000%
with 66 lines
in your changes are missing coverage. Please review.
Project coverage is 92.89%. Comparing base (
a3afe8b
) to head (79cf17b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
BTW Typescript doesn't pass, but this is because of isOverTime
so this should be resolved once you remove it.
In this PR, I'll breakdown my commits to add the functionality for fetching the data for the compare over time component. Although it's WIP, please feel free to review and comment as needed.
closes issue https://mozilla-hub.atlassian.net/browse/PCF-383
Compare over Time
compConcern:
I've profiled my patch (yay profiler ! - honestly learned so much profiling a gazillion times lol) and the jank is pretty significant for loading the results page for compare over time. It looks like the biggest problem is with the rendering, specifically React's
performWorkUntilDeadline
method. If we could brainstorm how to fix this, I'd appreciate it to move this patch along faster.