mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Config to fetch compare over time data #650

Closed Carla-Moz closed 4 months ago

Carla-Moz commented 5 months ago

In this PR, I'll breakdown my commits to add the functionality for fetching the data for the compare over time component. Although it's WIP, please feel free to review and comment as needed.

closes issue https://mozilla-hub.atlassian.net/browse/PCF-383

Concern:

I've profiled my patch (yay profiler ! - honestly learned so much profiling a gazillion times lol) and the jank is pretty significant for loading the results page for compare over time. It looks like the biggest problem is with the rendering, specifically React's performWorkUntilDeadline method. If we could brainstorm how to fix this, I'd appreciate it to move this patch along faster.

netlify[bot] commented 5 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 79cf17bfd00af56fb298303b4845c3f3ae72871e
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/664bf07899c6d50008534525
Deploy Preview https://deploy-preview-650--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 34.00000% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 92.89%. Comparing base (a3afe8b) to head (79cf17b).

Files Patch % Lines
src/components/CompareResults/overTimeLoader.ts 6.81% 33 Missing and 8 partials :warning:
.../components/CompareResults/OverTimeResultsView.tsx 50.00% 11 Missing :warning:
src/logic/treeherder.ts 0.00% 9 Missing and 1 partial :warning:
src/components/Search/CompareOverTime.tsx 71.42% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #650 +/- ## ========================================== - Coverage 97.15% 92.89% -4.27% ========================================== Files 65 67 +2 Lines 1405 1491 +86 Branches 242 258 +16 ========================================== + Hits 1365 1385 +20 - Misses 36 92 +56 - Partials 4 14 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

julienw commented 5 months ago

BTW Typescript doesn't pass, but this is because of isOverTime so this should be resolved once you remove it.