mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Donot render non expanded rows #653

Closed Carla-Moz closed 4 months ago

Carla-Moz commented 5 months ago

In this PR, the non expanded rows are not rendered unless expanded is true. Ran the profiler and it reduces the jank significantly especially in my compare-over-time patch. Closes https://mozilla-hub.atlassian.net/browse/PCF-439

netlify[bot] commented 5 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 971dd1d84fd216c10a063e27aace57919764bb03
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/6647922e3a0a7f0008c217e5
Deploy Preview https://deploy-preview-653--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.15%. Comparing base (d0392ac) to head (971dd1d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #653 +/- ## ========================================== - Coverage 97.86% 97.15% -0.72% ========================================== Files 65 65 Lines 1404 1405 +1 Branches 241 242 +1 ========================================== - Hits 1374 1365 -9 - Misses 28 36 +8 - Partials 2 4 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.