change the prop name to make it less confusing

Carla-Moz commented 4 months ago

The prop hasNonEditableState is confusing because of the double negative when using the false boolean. Let's make it positive, hasEditableState, so there's less cognitive load.

netlify[bot] commented 4 months ago

Deploy Preview for mozilla-perfcompare ready!

Name	Link
Latest commit	e8b2a189ef59c16641da445756445dc8f01c39c1
Latest deploy log	https://app.netlify.com/sites/mozilla-perfcompare/deploys/665e8be7e60d7a000820a4f9
Deploy Preview	https://deploy-preview-661--mozilla-perfcompare.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.18%. Comparing base (cfbe191) to head (69bcd7e).

:exclamation: Current head 69bcd7e differs from pull request most recent head e8b2a18

Please upload reports for the commit e8b2a18 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## beta #661 +/- ## ========================================== + Coverage 91.86% 97.18% +5.32% ========================================== Files 70 67 -3 Lines 1573 1492 -81 Branches 275 257 -18 ========================================== + Hits 1445 1450 +5 + Misses 102 38 -64 + Partials 26 4 -22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mozilla / perfcompare