Small refactor of some code related to the results filtering

julienw commented 4 months ago

This is a small PR in preparation for the filtering PR.

Commit 1 moves the "filter by search" code to ResultsTable (it was in ResultsMain). The goal is that all the filtering will be done in ResultsTable. Commit 2 moves the header cells configuration to ResultsTable as well (it was in ResultsHeader). The reason is that I'll want to add the filtering functions for each cell directly in this configuration object.

I also removed the test for TableHeader that wasn't doing much. I'm pretty sure it's covered by other files.

netlify[bot] commented 4 months ago

Deploy Preview for mozilla-perfcompare ready!

Name	Link
Latest commit	2a2d515f879cf1f8163c4452d6e2e3568a18a69f
Latest deploy log	https://app.netlify.com/sites/mozilla-perfcompare/deploys/666aef934d80ac0008831df6
Deploy Preview	https://deploy-preview-672--mozilla-perfcompare.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.40%. Comparing base (f7be860) to head (880ebfa).

:exclamation: Current head 880ebfa differs from pull request most recent head 2a2d515

Please upload reports for the commit 2a2d515 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## beta #672 +/- ## ========================================== - Coverage 91.46% 91.40% -0.06% ========================================== Files 69 69 Lines 1628 1618 -10 Branches 295 289 -6 ========================================== - Hits 1489 1479 -10 Misses 111 111 Partials 28 28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mozilla / perfcompare