search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

added edit mode to compare over time #674

Closed Carla-Moz closed 4 months ago

Carla-Moz commented 4 months ago

This PR adds the edit mode to compare over time, along with the read only mode for the selected base repo and time range text.

Closes Compare over time: edit feature for results page

Screenshot 2024-06-11 at 13 53 54 Screenshot 2024-06-11 at 13 54 02
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.47%. Comparing base (cae05b4) to head (d293034).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #674 +/- ## ========================================== + Coverage 91.25% 91.47% +0.21% ========================================== Files 70 70 Lines 1635 1653 +18 Branches 288 300 +12 ========================================== + Hits 1492 1512 +20 + Misses 114 112 -2 Partials 29 29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

netlify[bot] commented 4 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit d293034cd3412dd736ba8da9d86fd575a74b1746
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/666ccf421c19dd0008faa7fb
Deploy Preview https://deploy-preview-674--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Carla-Moz commented 4 months ago

@julienw, thanks for the review! I'll address the design bugs in a new PR.