Closed julienw closed 4 months ago
Name | Link |
---|---|
Latest commit | 642b308084b4d2c87b7876f7f63ce392585a3039 |
Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/666b032e36fadd0009f536ca |
Deploy Preview | https://deploy-preview-676--mozilla-perfcompare.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.37%. Comparing base (
171b896
) to head (73eb388
).:exclamation: Current head 73eb388 differs from pull request most recent head 642b308
Please upload reports for the commit 642b308 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR contains 2 small commits:
Commit 1: this removes some specific styles related to the popper variant of menus. These styles are not used because the "popper" variant isn't the default and we don't use it. Instead we use the Popover variant that is used by default for Menu, Select and possibly related things.
(Note: in the same files, there's a similar rule for the popover variant -- I'd like to change that in the future too, because they are inserted with a selector with a high specificity, and as a result this overrides other styles... but not now :-) ).
Commit 2: I noticed that the focus style (with a border) was making the element jump around a little bit in our select components. To fix that I added a border with a transparent color to all elements, and only changing the color when focused.
Before: Before.webm
After: After.webm