mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Small css fixes for dropdowns #676

Closed julienw closed 4 months ago

julienw commented 4 months ago

This PR contains 2 small commits:

Commit 1: this removes some specific styles related to the popper variant of menus. These styles are not used because the "popper" variant isn't the default and we don't use it. Instead we use the Popover variant that is used by default for Menu, Select and possibly related things.

(Note: in the same files, there's a similar rule for the popover variant -- I'd like to change that in the future too, because they are inserted with a selector with a high specificity, and as a result this overrides other styles... but not now :-) ).

Commit 2: I noticed that the focus style (with a border) was making the element jump around a little bit in our select components. To fix that I added a border with a transparent color to all elements, and only changing the color when focused.

Before: Before.webm

After: After.webm

netlify[bot] commented 4 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 642b308084b4d2c87b7876f7f63ce392585a3039
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/666b032e36fadd0009f536ca
Deploy Preview https://deploy-preview-676--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.37%. Comparing base (171b896) to head (73eb388).

:exclamation: Current head 73eb388 differs from pull request most recent head 642b308

Please upload reports for the commit 642b308 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #676 +/- ## ========================================== + Coverage 91.30% 91.37% +0.07% ========================================== Files 70 69 -1 Lines 1644 1611 -33 Branches 294 285 -9 ========================================== - Hits 1501 1472 -29 + Misses 114 111 -3 + Partials 29 28 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.