Move around some code so that the token retrieval is more self-contained

julienw commented 3 months ago

I moved around some code to make the authentication process more self contained and easier to work with. Now the call to getTaskclusterAccessToken will always return an access token: sometimes it will return the one stored in localStorage, sometimes it will trigger the taskcluster authentication.

I added a few TODO to be done in future PRs too.

netlify[bot] commented 3 months ago

Deploy Preview for mozilla-perfcompare ready!

Name	Link
Latest commit	9790b276c15fe1b60409a58bedb06fc86527c779
Latest deploy log	https://app.netlify.com/sites/mozilla-perfcompare/deploys/667c070bd113fb0008d9bd62
Deploy Preview	https://deploy-preview-683--mozilla-perfcompare.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (2b35734) to head (9790b27).

Files	Patch %	Lines
src/logic/credentials-storage.ts	50.00%	3 Missing and 1 partial :warning:
src/components/CompareResults/RetriggerButton.tsx	66.66%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## beta #683 +/- ## ========================================== + Coverage 91.70% 91.88% +0.18% ========================================== Files 71 71 Lines 1735 1738 +3 Branches 329 327 -2 ========================================== + Hits 1591 1597 +6 + Misses 114 112 -2 + Partials 30 29 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

julienw commented 3 months ago

Reviewed with Andra over zoom!

mozilla / perfcompare