Add modals for sign in and retriggers

julienw commented 3 months ago

5 commits:

Commit 1 adds the PNG icon for Taskcluster, along with some configuration so that it can be used with Jest and Webpack
Commit 2 adjusts the backdrop (the thing that's behind the modal to make the rest of page look darker) so that it's not darker in dark mode, but whiter instead
Commit 3 implements the rough logic of moving around modals with some skeletons for the modals themselves
Commit 4 implements the Sign in modal
Commit 5 implements the Retrigger modal

Tell me what you think!

Deploy preview

Capture vidéo du 2024-06-28 18-28-51.webm

netlify[bot] commented 3 months ago

Deploy Preview for mozilla-perfcompare ready!

Name	Link
Latest commit	3d41efd410aa9fb889f47d14533febaf9738f6b7
Latest deploy log	https://app.netlify.com/sites/mozilla-perfcompare/deploys/6682d5dd01ddb200089c60a5
Deploy Preview	https://deploy-preview-684--mozilla-perfcompare.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 63.85542% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (d113686) to head (3d41efd).

Files	Patch %	Lines
...nents/CompareResults/Retrigger/RetriggerButton.tsx	57.50%	17 Missing :warning:
.../CompareResults/Retrigger/RetriggerConfigModal.tsx	43.75%	9 Missing :warning:
.../CompareResults/Retrigger/RetriggerSignInModal.tsx	83.33%	3 Missing :warning:
src/theme/components.js	66.66%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## beta #684 +/- ## ========================================== - Coverage 89.50% 88.78% -0.72% ========================================== Files 71 74 +3 Lines 1791 1846 +55 Branches 332 338 +6 ========================================== + Hits 1603 1639 +36 - Misses 157 176 +19 Partials 31 31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Carla-Moz commented 3 months ago

Screenshot 2024-06-28 at 10 51 31

Maybe we can add more line height here ? The 'g' in 'Sign' is touching the 't' in 'trigger'

julienw commented 3 months ago

Maybe we can add more line height here ? The 'g' in 'Sign' is touching the 't' in 'trigger'

I agree but looking closer I think we should increase the line-height to 1.5 everywhere in the project, not just here, so I'll file a jira ticket for this.

mozilla / perfcompare