search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Display a notification to the user after the retrigger request is sent #703

Closed julienw closed 2 months ago

julienw commented 2 months ago

This dislpays a notification for each retrigger request: one for base and one for new. I tried to merge them, but found that it looked better with 2 individual notifications. Please tell me if you think otherwise :-)

Also updated tests.

Do not look at the first commits, they are coming from Andra's PR #695 because my tests build on them.

image

I tested from this results page but retriggers don't work from a deploy preview, so if you want to try you need to checkout the pull request on your local computer.

netlify[bot] commented 2 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 8fe0f42821db9fdbb9a258e5fffbeb03b165473a
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66b5e95e212b790008822696
Deploy Preview https://deploy-preview-703--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.07%. Comparing base (ef1daff) to head (c6f80ef). Report is 4 commits behind head on beta.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #703 +/- ## ========================================== + Coverage 86.01% 86.07% +0.05% ========================================== Files 83 83 Lines 2110 2119 +9 Branches 389 391 +2 ========================================== + Hits 1815 1824 +9 Misses 258 258 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.